[MediaWiki-commits] [Gerrit] ve.track: add topic-based analytic event subscription - change (mediawiki...VisualEditor) | Wikipedia | Mediawiki-CVS
this category
[MediaWiki-commits] [Gerrit] ve.track: add topic-based analytic event subscription - change (mediawiki...VisualEditor)
Oct&11,&&PM
Post #1 of 3
(102 views)
[MediaWiki-commits] [Gerrit] ve.track: add topic-based analytic event subscription - change (mediawiki...VisualEditor)
Ori.livneh has uploaded a new change for review.
Change subject: ve.track: add topic-based analytic event subscription ......................................................................
ve.track: add topic-based analytic event subscription
Replace ve.trackRegisterHandler with ve.trackSubscribe, which takes an additional string argument 'topic', specifying a string prefix on which to match events.
Also simplifies the argument-handling by eliminating variadic ve.track calls in favor of a single object that encodes all event data. The loose coupling of track event emitters and subscribers makes relying on unnamed positional argument property access works better.
I did not deprecate ve.trackRegisterHandler because its only user is WikimediaEvents. I commit to updating it to use 've.trackRegisterHandler || ve.trackSubscribe' if this is merged.
Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 --- M modules/ve/ve.track.js 1 file changed, 18 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/36/89336/1
diff --git a/modules/ve/ve.track.js b/modules/ve/ve.track.js index 4455530..c1b0a6f 100644 --- a/modules/ve/ve.track.js +++ b/modules/ve/ve.track.js @@ -18,11 +18,11 @@
* generic interface for routing these events to an analytics framework.
* @member ve -
* @param {string} name Event name +
* @param {string} topic Event name
* @param {Mixed...} [data] Data to log
ve.track = function () { -
queue.push( { context: { timeStamp: ve.now() }, args: arguments } ); +
ve.track = function ( topic, data ) { +
queue.push( { topic: topic, timeStamp: ve.now(), data: data } );
callbacks.fire( queue );
@@ -31,17 +31,27 @@
* Handlers will be called once for each tracked event, including any events that fired before the
* ha 'this' is set to a plain object with a 'timeStamp' property indicating -
* the exact time at which the event fired. +
* the exact time at which the event fired and a string 'topic' property.
* @member ve +
* @param {string} [topic=""] Handle events whose name starts with this string prefix
* @param {Function} callback
ve.trackRegisterHandler = function ( callback ) { -
var invocation, seen = 0; +
ve.trackSubscribe = function ( topic, callback ) { +
var seen = 0; + +
if ( arguments.length === 1 ) { +
callback = +
topic = ''; +
callbacks.add( function ( queue ) { +
for ( ; seen & queue. seen++ ) { -
invocation = queue[ seen ]; -
callback.apply( invocation.context, invocation.args ); +
event = queue[ seen ]; +
if ( event.topic.indexOf( topic ) === 0 ) { +
callback.call( event, event.topic, event.data ); +
To view, visit
To unsubscribe, visit
Gerrit-MessageType: newchange Gerrit-Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ori.livneh &ori [at] wikimedia&
_______________________________________________ MediaWiki-commits mailing list MediaWiki-commits [at] lists
Oct&16,&&AM
Post #2 of 3
(97 views)
[MediaWiki-commits] [Gerrit] ve.track: add topic-based analytic event subscription - change (mediawiki...VisualEditor)
jenkins-bot has submitted this change and it was merged.
Change subject: ve.track: add topic-based analytic event subscription ......................................................................
ve.track: add topic-based analytic event subscription
Replace ve.trackRegisterHandler with two methods: ve.trackSubscribe and ve.trackSubscribeAll. The former takes an additional string argument 'topic', which specifies a string prefix on which to match event names. The callback is only called on matching events. The latter, ve.trackSubscribeAll, binds a handler to all track events, regardless of topic.
This patch simplifies argument-handling by eliminating variadic ve.track calls in favor of a single object that encodes all event data. The loose coupling of track event emitters and subscribers makes relying on unnamed positional argument property access works better.
Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 --- M modules/ve/ve.track.js 1 file changed, 33 insertions(+), 14 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.track.js b/modules/ve/ve.track.js index 4455530..c457fd8 100644 --- a/modules/ve/ve.track.js +++ b/modules/ve/ve.track.js @@ -18,31 +18,50 @@
* generic interface for routing these events to an analytics framework.
* @member ve -
* @param {string} name Event name -
* @param {Mixed...} [data] Data to log +
* @param {string} topic Event name +
* @param {Object} [data] Additional data describing the event, encoded as an object
ve.track = function () { -
queue.push( { context: { timeStamp: ve.now() }, args: arguments } ); +
ve.track = function ( topic, data ) { +
queue.push( { topic: topic, timeStamp: ve.now(), data: data } );
callbacks.fire( queue );
* Register a handler for analytic events. +
* Register a handler for subset of analytic events, specified by topic
* Handlers will be called once for each tracked event, including any events that fired before the
* ha 'this' is set to a plain object with a 'timeStamp' property indicating -
* the exact time at which the event fired. +
* the exact time at which the event fired, a string 'topic' property naming the event, and a +
* 'data' property which is an object of event-specific data. The event topic and event data are +
* also passed to the callback as the first and second arguments, respectively. +
* @member ve +
* @param {string} topic Handle events whose name starts with this string prefix +
* @param {Function} callback Handler to call for each matching tracked event +
ve.trackSubscribe = function ( topic, callback ) { +
var seen = 0; + +
callbacks.add( function ( queue ) { +
for ( ; seen & queue. seen++ ) { +
event = queue[ seen ]; +
if ( event.topic.indexOf( topic ) === 0 ) { +
callback.call( event, event.topic, event.data ); +
* Register a handler for all analytic events +
* Like ve#trackSubscribe, but binds the callback to all events, regardless of topic.
* @member ve
* @param {Function} callback
ve.trackRegisterHandler = function ( callback ) { -
var invocation, seen = 0; -
callbacks.add( function ( queue ) { -
for ( ; seen & queue. seen++ ) { -
invocation = queue[ seen ]; -
callback.apply( invocation.context, invocation.args ); -
ve.trackSubscribeAll = function ( callback ) { +
ve.trackSubscribe( '', callback );
To view, visit
To unsubscribe, visit
Gerrit-MessageType: merged Gerrit-Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ori.livneh &ori [at] wikimedia& Gerrit-Reviewer: Catrope &roan.kattouw [at] gmail& Gerrit-Reviewer: Ori.livneh &ori [at] wikimedia& Gerrit-Reviewer: Trevor Parscal &tparscal [at] wikimedia& Gerrit-Reviewer: jenkins-bot
_______________________________________________ MediaWiki-commits mailing list MediaWiki-commits [at] lists
Oct&16,&&PM
Post #3 of 3
(99 views)
[MediaWiki-commits] [Gerrit] ve.track: add topic-based analytic event subscription - change (mediawiki...VisualEditor)
jenkins-bot has submitted this change and it was merged.
Change subject: ve.track: add topic-based analytic event subscription ......................................................................
ve.track: add topic-based analytic event subscription
Replace ve.trackRegisterHandler with two methods: ve.trackSubscribe and ve.trackSubscribeAll. The former takes an additional string argument 'topic', which specifies a string prefix on which to match event names. The callback is only called on matching events. The latter, ve.trackSubscribeAll, binds a handler to all track events, regardless of topic.
This patch simplifies argument-handling by eliminating variadic ve.track calls in favor of a single object that encodes all event data. The loose coupling of track event emitters and subscribers makes relying on unnamed positional argument property access works better.
Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 (cherry picked from commit 495f3a9e40ad4bed91535) --- M modules/ve/ve.track.js 1 file changed, 33 insertions(+), 14 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.track.js b/modules/ve/ve.track.js index 4455530..c457fd8 100644 --- a/modules/ve/ve.track.js +++ b/modules/ve/ve.track.js @@ -18,31 +18,50 @@
* generic interface for routing these events to an analytics framework.
* @member ve -
* @param {string} name Event name -
* @param {Mixed...} [data] Data to log +
* @param {string} topic Event name +
* @param {Object} [data] Additional data describing the event, encoded as an object
ve.track = function () { -
queue.push( { context: { timeStamp: ve.now() }, args: arguments } ); +
ve.track = function ( topic, data ) { +
queue.push( { topic: topic, timeStamp: ve.now(), data: data } );
callbacks.fire( queue );
* Register a handler for analytic events. +
* Register a handler for subset of analytic events, specified by topic
* Handlers will be called once for each tracked event, including any events that fired before the
* ha 'this' is set to a plain object with a 'timeStamp' property indicating -
* the exact time at which the event fired. +
* the exact time at which the event fired, a string 'topic' property naming the event, and a +
* 'data' property which is an object of event-specific data. The event topic and event data are +
* also passed to the callback as the first and second arguments, respectively. +
* @member ve +
* @param {string} topic Handle events whose name starts with this string prefix +
* @param {Function} callback Handler to call for each matching tracked event +
ve.trackSubscribe = function ( topic, callback ) { +
var seen = 0; + +
callbacks.add( function ( queue ) { +
for ( ; seen & queue. seen++ ) { +
event = queue[ seen ]; +
if ( event.topic.indexOf( topic ) === 0 ) { +
callback.call( event, event.topic, event.data ); +
* Register a handler for all analytic events +
* Like ve#trackSubscribe, but binds the callback to all events, regardless of topic.
* @member ve
* @param {Function} callback
ve.trackRegisterHandler = function ( callback ) { -
var invocation, seen = 0; -
callbacks.add( function ( queue ) { -
for ( ; seen & queue. seen++ ) { -
invocation = queue[ seen ]; -
callback.apply( invocation.context, invocation.args ); -
ve.trackSubscribeAll = function ( callback ) { +
ve.trackSubscribe( '', callback );
To view, visit
To unsubscribe, visit
Gerrit-MessageType: merged Gerrit-Change-Id: I3b58ce0f48ad3c9b56fcaa9c2226cc79bbcd4051 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: wmf/1.22wmf21 Gerrit-Owner: Jforrester &jforrester [at] wikimedia& Gerrit-Reviewer: Ori.livneh &ori [at] wikimedia& Gerrit-Reviewer: jenkins-bot
_______________________________________________ MediaWiki-commits mailing list MediaWiki-commits [at] lists
&&&&Foundation
&&&&Wikitech
&&&&WikiMania
&&&&Mediawiki
&&&&Mediawiki-announce
&&&&Mediawiki-CVS
Interested in having your list archived?
Powered by Gossamer Threads Inc.如何解决jbosstools在windows中不支持64位jsp文件预览的问题 - JBoss SEAM - ITeye群组
电脑上安装的基本配置是
java SDK 1.6（64bit）+Jboss 7.0（64bit）+eclipse3.7.1-win32-x86_64
win7的操作系统。
在web编程的时候，jsp文件预览功能会出现以下错误：
Could not open the Visual Page Editor:
Current platform 'win32.win32.x86_64' is not supported.
查看了jboss的FAQ，发现是再windows下面目前只支持32位的java，那现在是不是只能重新全部安装成32位的才能解决啊？
参照网址：http://community.jboss.org/wiki/JBosstoolsVisualEditorFAQ
Q: Which platforms are supported by Visual Editor?
A: The list of supported platforms (and their IDs):
Windows with Java 32-bit (win32.win32.x86)
Linux x86 (gtk.linux.x86)
Linux x86-64 (gtk.linux.x86_64)
Mac OS X Cocoa with Java 32-bit (cocoa.macosx.x86)
Mac OS X Carbon with Java 32-bit (carbon.macosx.x86) [not supported by JBoss Tools 3.3.0 and later, JBDS 5.0 and later]
In brief, Java 64-bit is supported on Linux only, on all other systems Visual Editor requires Java 32-bit.
没有人知道……
换用32位的jdk和eclipse就可以了。应该是 Visual Editor不支持64位的预览功能。Eclipse&visual&editor安装&（转载）
关键字：Eclipse3.5插件、Visual
Editor安装、EMF、GEF、VisualEditor面板、palette
最近需要开发一个Eclipse插件，Google了一下，在IBM
developerWorks找到很多精彩的文章，对Eclipse插件开发也有了初步的了解，特此分享~
接下来讲下安装的注意事项(注：我的Eclipse版本为3.5，以下插件安装均基于此版本)：
Visual Editor安装方法：,其中需要注意的是安装VE前必须安装其依赖的另外两个插件---&&&EMF和GEF
EMF下载地址：，选择All-In-One
Site下载到本地,然后在Eclipse中选择Help---&&&Install
New Software---&&&Work
with---&&&Add---&&&Archive
---&&&Location：%本地EMF
zip文件%； Name:EMF
---&&&OK---&&&Work
with下拉框选择刚才配置的EMF
site---&&&Name里面选择EMF/XSD
All-In-One SDK (The combined SDK for EMF and XSD,
including source, documentation, and
examples.)---Next---&&&Finish.
参考以下截图：
GEF下载地址：。 安装方法同EMF类似，
安装完EMF和GEF后，就可以正常安装VE了！
安装插件的时候需要等候一段时间，要耐心哦~~
安装成功以后，重启Eclipse,Help---&&&About
SDK---&&&Installation
Details---&&&Installed
Software里面应该可以看到我们刚才安装的插件---&&&如下图
project---&&& New
---&&&Other---&&&
Java选择Visual
Class---&&&
进入Visual
Class设计页面，我们会发现并没有VisualEditor面板，因此找不到Swing/awt组件，解决方法：
Window---&&&Show
View---&&&Other---&&&General---&&&Palette---&&&Ok.
关键字：Eclipse3.5插件、Visual
Editor安装、EMF、GEF、VisualEditor面板、palette
最近需要开发一个Eclipse插件，Google了一下，在IBM
developerWorks找到很多精彩的文章，对Eclipse插件开发也有了初步的了解，特此分享~
接下来讲下安装的注意事项(注：我的Eclipse版本为3.5，以下插件安装均基于此版本)：
Visual Editor安装方法：,其中需要注意的是安装VE前必须安装其依赖的另外两个插件---&&&EMF和GEF
EMF下载地址：，选择All-In-One
Site下载到本地,然后在Eclipse中选择Help---&&&Install
New Software---&&&Work
with---&&&Add---&&&Archive
---&&&Location：%本地EMF
zip文件%； Name:EMF
---&&&OK---&&&Work
with下拉框选择刚才配置的EMF
site---&&&Name里面选择EMF/XSD
All-In-One SDK (The combined SDK for EMF and XSD,
including source, documentation, and
examples.)---Next---&&&Finish.
参考以下截图：
GEF下载地址：。 安装方法同EMF类似，
安装完EMF和GEF后，就可以正常安装VE了！
安装插件的时候需要等候一段时间，要耐心哦~~
安装成功以后，重启Eclipse,Help---&&&About
SDK---&&&Installation
Details---&&&Installed
Software里面应该可以看到我们刚才安装的插件---&&&如下图
project---&&& New
---&&&Other---&&&
Java选择Visual
Class---&&&
进入Visual
Class设计页面，我们会发现并没有VisualEditor面板，因此找不到Swing/awt组件，解决方法：
Window---&&&Show
View---&&&Other---&&&General---&&&Palette---&&&Ok.
已投稿到：
以上网友发言只代表其个人观点，不代表新浪网的观点或立场。